Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorative shapes overlap section subheadings #457

Open
shyusu4 opened this issue Jan 31, 2024 · 4 comments
Open

Decorative shapes overlap section subheadings #457

shyusu4 opened this issue Jan 31, 2024 · 4 comments
Labels

Comments

@shyusu4
Copy link
Member

shyusu4 commented Jan 31, 2024

Issue

Decorative shapes are currently overlapping with section subheadings.

Decorative shape overlapping section subheading in dark mode of wagtail.org Decorative shape overlapping section subheading on website in light mode of wagtail.org

Steps to reproduce
Resize the viewport to 768px or less.

Suggested fix
Make sure icons are always behind text elements in z-index layering or/and add a solid background according to theme behind the text.

Reference
Wagtail.org | Accessibility audit spreadsheet

@thibaudcolas
Copy link
Member

There’s been some improvements in #458 but I think there’s more work to do on this.

@PAVAN507-STAR
Copy link

@thibaudcolas I would love take on this issue sir.If possible can u guide me on what more changes to add.

@thibaudcolas
Copy link
Member

@PAVAN507-STAR I think the suggested fix above is good?

  1. Make sure icons are always behind text elements in z-index layering
  2. add a solid background according to theme behind the text.

They both sound like valuable improvements.

@PAVAN507-STAR
Copy link

@thibaudcolas Okay sir will do that in 2-3 days if that's fine as rn i have clg exams going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants