Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadTheDocs notifications for PR builds and older versions do not show up #296

Closed
laymonage opened this issue Oct 29, 2024 · 2 comments
Closed
Assignees

Comments

@laymonage
Copy link
Member

Not sure how to fix this yet, but it seems we no longer have the admonition that shows up on PR builds and older versions:

Note – You are not reading the most recent version of this documentation. v6.2.2 is the latest version available.

I manually edited that in Wagtail's docs to demonstrate. This used to show up automatically. I think it's added by RTD's script.

The admonition not showing up anymore might be related to the new Read the Docs Addons enabled by default, and that some injected Sphinx context has been removed: readthedocs/readthedocs.org#11474

It seems RTD is moving towards this new Notification add-on:

Image

Which I believe comes from this setting on the dashboard:

Image

However, that new notification popup at the top right seems to only trigger in old versions of Wagtail's docs where we still used RTD's theme:

This leads me to believe there's something in our theme that's causing the toast notification not to show up.

Also, not sure if this is related, but as you can see the old-style admonition doesn't show up in the v2.12 docs. However, in the v2.2 docs https://docs.wagtail.org/en/v2.2.2/, you can see both the old-style admonition and the new toast notification.

@laymonage laymonage self-assigned this Oct 29, 2024
@laymonage laymonage moved this from 🔖 Ready to 🏗 In progress in Wagtail 6.3 release planning Oct 29, 2024
@laymonage
Copy link
Member Author

Turns out the element is there – but again, Bootstrap messes with it because RTD uses a generic .toast class rather than a namespaced class name.

Image

See opacity: 0; at the bottom right.

I've raised readthedocs/addons#413.

Maybe it's time we move away from Bootstrap too, as noted in #254 (comment)...

@laymonage
Copy link
Member Author

Fixed in #299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

No branches or pull requests

1 participant