Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc UI issues #10

Open
tomdyson opened this issue May 14, 2019 · 1 comment
Open

Misc UI issues #10

tomdyson opened this issue May 14, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@tomdyson
Copy link
Contributor

  1. It's not clear that you have to click + after adding a reviewer in the 'Submit for review' modal. If there's only one person in the reviewers box 'Start review' should submit with that person.
  2. The list of reviewers need indenting
  3. The [x] delete link should be a bin icon
  4. If the user requesting a review doesn't have a name, the email should fall back to their email address
  5. The styling of the pencil edit icon, the comment box pop-up and the pop-up comment view are inconsistent with Wagtail
  6. The styling of the 'Submit your review' box needs improving
  7. The options for review should be 'approve', 'reject', 'just comment'
  8. The styling of the 'thank you' screen should be improved
  9. Reviews should be highlighted in the admin dashboard
  10. The review dashboard should show dates, and should be in reverse chronological order
  11. Once reviews have been closed, they should disappear from the review dashboard
  12. The per-page reviews view should show reviews in reverse chronological order
@tomdyson tomdyson added the enhancement New feature or request label May 14, 2019
@benenright
Copy link

benenright commented May 15, 2019

Hi

Here is a mockup addressing issues in point 1 above list:
https://invis.io/SPS0Y1OEDZU#/363433471_add-Reviewer

  • shorter input and update to the + btn so its more in sight and explicitly says 'Add reviewer
  • new styling on added reviewers
  • clearer language 'Request review' in btn

Here are a series of mockups that address points 5, 6 + 7 in the above list:
https://invis.io/SPS0Y1OEDZU#/363433470_select-Text

  • a new, dark theme to look slicker and fit better with Wagtail style

For developer:
Sketch file attached. Or request to be added to the Invision project and use Inspect to get CSS values.

Ben

wagtail-review-mockups.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants