bug: Fallback public client with WS transport doesn't use eth_subscribe

[arjun-io]

Is there an existing issue for this?

• I have searched the existing issues

Package Version

1.1.6

Current Behavior

When using a fallback provider with a websocket transport underneath, the provider does not use subscriptions and instead reverts to polling over the websocket connection.

Expected Behavior

If a fallback provider is used, and the attempted transport being used is websocket, use eth_subscribe

Steps To Reproduce

See minimal repo -> Network Inspector -> Websocket connection

Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)

https://stackblitz.com/edit/viem-getting-started-ynbq9a?file=index.ts

Anything else?

No response

[arjun-io]

Since the eth_subscribe based functions only check for the top level transport (https://github.com/wagmi-dev/viem/blob/main/src/actions/public/watchBlocks.ts#L100) and the fallback transport doesn't have any ability to surface the type of transport it is attempting, it might take a bit of a refactor to handle this... Potentially the fix here is to give some level of introspection to the fallback transports currently used transport and use that in the enablePolling check?

Edit: An alternative easy fix might be to change the type here: https://github.com/wagmi-dev/viem/blob/main/src/clients/transports/fallback.ts#L146 to something like

type: transports.every(t => t.type === 'webSocket') ? 'webSocket' : 'fallback'

and also exposing the subscribe function of the transport

[deHB6]

Experiencing this as well, when I add webSocketPublicClient, watch: true no longer works on my useContractReads

[wk0]

is this still a problem?

[arjun-io]

is this still a problem?

It appears show, I just retried the stackblitz with an updated version of Viem.

[github-actions]

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Viem version. If you have any questions or comments you can create a new discussion thread.