-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using "maxNodes" crashes with "No (correct) mutate method given" #128
Comments
I've created PR #129. Seems to no longer crash. |
How is maxNodes/maxConns/ etc meant to work? I'm still going over the maximum number I set in Neat and therefore it's overfitting. My current settings:
|
Hey @alaa-eddine I saw you originally did the pull request for this feature. Since this project is now unmaintained, I'm hoping maybe you could see why the max settings are not working? |
Hi @dan-ryan just wanted to let you know that we're maintaining a spin-off of Neataptic, just noted this issue and incorporated your changes. We would love to add you as a contributor and give you credit: https://github.com/liquidcarrot/carrot hope to see you there! 👍 |
@christianechevarria Oh nice. After all these years there hasn't been another replacement for Neataptic so good to see. |
My pull request still didn't fix the issue that the network was going over maxNodes and maxConns. So someone should look at that. Do you have a changelog for the differences from Neatapic to the latest version of Carrot? |
When using
maxNodes
ormaxConns
it crashes my app. I'm using version 1.4.7.Looking at the codebase, it looks like selectMutationMethod can return undefined and therefore can be passed into the mutate method which crashes.
Looks like the original pull request (https://github.com/wagenaartje/neataptic/pull/62/files) used to return nulls.
The text was updated successfully, but these errors were encountered: