Skip to content

Commit 0bceedf

Browse files
Merge branch 'issue1278_split_recordings' into issue1205_externalEpoch
2 parents aa49ca1 + 7a793a8 commit 0bceedf

File tree

4 files changed

+21
-11
lines changed

4 files changed

+21
-11
lines changed

R/g.report.part6.R

+1
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ g.report.part6 = function(metadatadir = c(), f0 = c(), f1 = c(),
7777
#-------------------------------------------------------------
7878
# store all summaries in csv files
7979
outputfinal_clean = tidyup_df(outputfinal)
80+
outputfinal_clean = addSplitNames(outputfinal_clean) # If recording was split
8081
data.table::fwrite(outputfinal_clean, paste0(metadatadir, "/results/part6_summary.csv"),
8182
row.names = FALSE, na = "", sep = params_output[["sep_reports"]],
8283
dec = params_output[["dec_reports"]])

R/splitRecords.R

+11-5
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ splitRecords = function(metadatadir, params_general = NULL) {
7676
if (splitTime_tmp[1] > timestamp_short[1]) {
7777
segment_starts = timestamp_short[1]
7878
segment_ends = splitTime_tmp[1]
79-
segment_names = paste0("startTO", split_names[1])
79+
segment_names = paste0("startrecTO", split_names[1])
8080
}
8181
for (segment_index in 1:length(splitTime_tmp)) {
8282
if (segment_index < length(splitTime_tmp)) {
@@ -88,7 +88,7 @@ splitRecords = function(metadatadir, params_general = NULL) {
8888
segment_starts = c(segment_starts, splitTime_tmp[segment_index])
8989
segment_ends = c(segment_ends, timestamp_short[length(timestamp_short)])
9090
segment_names = c(segment_names, paste0(split_names[segment_index],
91-
"TOend"))
91+
"TOendrec"))
9292
}
9393
}
9494
# Store each part separately
@@ -135,10 +135,16 @@ splitRecords = function(metadatadir, params_general = NULL) {
135135
}
136136
newFileName = paste0(newfilebase, id_separator, "split", g, "_", segment_names[g], ".", extension)
137137
# add back to I$filename because part 2 uses this in the csv report
138-
I$filename = gsub(pattern = "meta_", replacement = "", x = newFileName)
139-
newFileName = paste0(dirname(S$filename[j]), "/", newFileName)
140-
newRDataFileName = paste0(newFileName, ".RData")
138+
filename_dir = gsub(pattern = "meta_", replacement = "", x = newFileName)
139+
I$filename = filename_dir
140+
newRDataFileName = paste0(dirname(S$filename[j]), "/", newFileName, ".RData")
141141
file_was_split = TRUE
142+
143+
# update weekday code and name
144+
M$wday = as.POSIXlt(x = timestamp_short[1], tz = desiredtz)$wday
145+
weekdays = c("Sunday","Monday","Tuesday","Wednesday","Thursday","Friday","Saturday")
146+
M$wdayname = weekdays[M$wday + 1]
147+
# save
142148
save(M, C, I,
143149
filefoldername, filename_dir, tail_expansion_log,
144150
file = newRDataFileName)

man/GGIR.Rd

+5-2
Original file line numberDiff line numberDiff line change
@@ -286,8 +286,11 @@ GGIR(mode = 1:5,
286286
format is specified with parameter \code{recording_split_timeformat}.
287287
The names of these columns are used to refer to each resulting segment.
288288
To prevent extremely long file name GGIR ignores spaces and does not consider
289-
more than 10 characters which are forced to lower case. This functionality
290-
is applied after all other aspect of GGIR part 1 are completed for all input files.
289+
more than 10 characters which are forced to lower case. If the recording
290+
starts before or ends after the first and last split time then the start and/or
291+
end of the recording is also used as split time and referred to as
292+
startrec and endrec, respectively. Files are split after all other aspect of
293+
GGIR part 1 are completed for all input files.
291294
}
292295

293296
\item{recording_split_timeformat}{

tests/testthat/test_splitRecords.R

+4-4
Original file line numberDiff line numberDiff line change
@@ -46,18 +46,18 @@ test_that("Recording can be split", {
4646
# File created?
4747
expect_true(dir.exists("./testfolder/meta/basic"))
4848
expect_equal(length(dir("./testfolder/meta/basic")), 2)
49-
expect_true(file.exists("./testfolder/meta/basic/meta_1_1-1-1900_split1_startTOtime1.bin.RData"))
50-
expect_true(file.exists("./testfolder/meta/basic/meta_1_1-1-1900_split2_time1TOend.bin.RData"))
49+
expect_true(file.exists("./testfolder/meta/basic/meta_1_1-1-1900_split1_startrecTOtime1.bin.RData"))
50+
expect_true(file.exists("./testfolder/meta/basic/meta_1_1-1-1900_split2_time1TOendrec.bin.RData"))
5151

5252
# File content correct?
53-
load("./testfolder/meta/basic/meta_1_1-1-1900_split1_startTOtime1.bin.RData")
53+
load("./testfolder/meta/basic/meta_1_1-1-1900_split1_startrecTOtime1.bin.RData")
5454
expect_equal(nrow(M$metashort), 8100)
5555
expect_equal(nrow(M$metalong), 45)
5656
expect_equal(M$metashort$timestamp[1], "2013-11-14T11:45:00+0000")
5757
expect_equal(tail(M$metashort$timestamp, n = 1), "2013-11-14T22:59:55+0000")
5858
expect_equal(M$metalong$timestamp[1], "2013-11-14T11:45:00+0000")
5959
expect_equal(tail(M$metalong$timestamp, n = 1), "2013-11-14T22:45:00+0000")
60-
load("./testfolder/meta/basic/meta_1_1-1-1900_split2_time1TOend.bin.RData")
60+
load("./testfolder/meta/basic/meta_1_1-1-1900_split2_time1TOendrec.bin.RData")
6161
expect_equal(nrow(M$metashort), 10619)
6262
expect_equal(nrow(M$metalong), 58)
6363
expect_equal(M$metashort$timestamp[1], "2013-11-14T23:00:00+0000")

0 commit comments

Comments
 (0)