Possible to merge Freed-Wu/coc-jq?

[wader]

No description provided.

[wader]

👋 @Freed-Wu would it be possible to merge your changes into vscode-jq and make it possible to share code base? I haven't used coc.nvim myself, how does it differ from using neovim with jq-lsp? does more things like highlighting, snippets etc?

[Freed-Wu]

I think you should open this issue in https://github.com/Freed-Wu/coc-jq 😄

[Freed-Wu]

This is difference:

Freed-Wu@73af4e2

And dependence should be changed to coc.nvim

[wader]

Sorry I should have been clearer 😄

I didn't see any "Issues" tab on your fork but now i see it, i was probably just temporary confused. That's why i created an issue on my repo instead.

By difference i meant how using coc with vscode-jq is different user experience-wise compared to using neovim + jq-lsp.

The point of this issue was to see if it would be possible to use vscode-jq with both vscode and coc somehow? the code diff didn't look that much so it seems possible? or is it common that one has to fork vscode extensions and modify them to use with coc?

[Freed-Wu]

By difference i meant how using coc with vscode-jq is different user experience-wise

You can see https://github.com/neoclide/coc.nvim/wiki/Using-coc-extensions

use vscode-jq with both vscode and coc somehow

You can notice Freed-Wu@73af4e2 , there are some difference between vscode and coc.nvim's APIs, I do not know how to use them without any modification. Maybe you can ask the maintainer of coc.nvim? @fannheyward

[fannheyward]

Thank you for your ping!

There are at least two things that need to change to port a VSCode extension to coc.nvim:

1. the import, Freed-Wu@73af4e2#diff-7b7aa9c8b1944a19471cbe4172196463223080d88b4433c79933f3a47f8ca0f3R1
2. the package.json https://github.com/Freed-Wu/coc-jq/blob/master/package.json , dev dependencies etc

You can refer to the practice of vscode-ltex

1. coc.nvim's whole package.json content https://github.com/valentjn/vscode-ltex/blob/74484ff6e0f1f810fc24d57ba51286c347b31cf3/package.json#L2668
2. placeholder in source https://github.com/valentjn/vscode-ltex/blob/74484ff6e0f1f810fc24d57ba51286c347b31cf3/src/extension.ts#L8
3. patchForTarget.py and CI to patch

[wader]

@fannheyward Thanks for the references, that makes things clearer

I haven't really needed to touch vscode-jq much as most of the logic is in https://github.com/wader/jq-lsp so maybe it's not a big maintenance burden to maintain a fork.

Think i would be fine doing something like what vscode-ltex does also if @Freed-Wu is up for trying it. I've already thought about packaging a vsxi for vscode-jq but haven't gotten around to do it.

Lastly thanks for helping making my jq dev tools easier to use and accessible!