New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appId 和 appSecret不要作为各个类的构造参数 #114

Closed

keepeye opened this issue Sep 25, 2015 · 1 comment

Labels

Feature

Milestone

keepeye commented Sep 25, 2015

理由如下：
一旦access_token通过中控服务器管理，就没法玩了。

个人建议：
new Notice($appId,$appSecret)
改为
new Notice(new AccessToken($appId,$appSecret))

解耦。

耦合现象比较多，如果通过di来控制，会不会更好些？当然，这只是我的个人小小的建议。

Collaborator

overtrue commented Sep 25, 2015

理解，3.0已经是这样的了（测试中，还没完全开发完成）

overtrue added the Feature label

overtrue added this to the 3.0 milestone

overtrue closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment