diff --git a/evaluations/polkadot-js-extension-per-account-auth_1_CrommVardek.md b/evaluations/polkadot-js-extension-per-account-auth_1_CrommVardek.md new file mode 100644 index 0000000000..5dd8c8fc9b --- /dev/null +++ b/evaluations/polkadot-js-extension-per-account-auth_1_CrommVardek.md @@ -0,0 +1,26 @@ +# Evaluation + +- **Status:** Accepted +- **Application Document:** https://github.com/w3f/Grants-Program/blob/master/applications/polkadot-js-extension-per-account-auth.md +- **Milestone:** Number 1 +- **Kusama Identity:** JCkD7cRTpfkQmk5v6XvWvR1JPTvrouPXSGmQqtWPcJQKFzx +- **Previously successfully merged evaluation:** N/A + +| Number | Deliverable | Accepted | Link | Evaluation Notes | +| ------ | ----------- | -------- | ---- |----------------- | +| 0b. | Documentation | | | Missing Documentation | +| 0e. | Article | | | Missing Article | +| 1. | new approval screen || [PR](https://github.com/polkadot-js/extension/pull/1068) | | +| 2. | new approval back-end | | [PR](https://github.com/polkadot-js/extension/pull/1068) | | +| 3. | website approval enhancement | | [PR](https://github.com/polkadot-js/extension/pull/1068) | | +| 4. | Test implementation | | [PR](https://github.com/polkadot-js/extension/pull/1068), [Commit](https://github.com/polkadot-js/extension/pull/1068/commits/cd3a40b33cfed9d4196472419e96fa71beffb58b) | Was not planned, but always nice to have added a test. | + +Ideally all links inside the above table should include the commit hash, +which was used for testing the delivery. It should also be checked if the software is published under the correct open-source license. + +## General Notes + +As I'm not familiar with polkadot-js extension's source code, it was not straight forward to link the changed files to a delivery step (as all delivery steps are linekd to the same PR). +It would have been nice to maybe link the corresponding commit(s) instead of the same PR. Hopefully the files changes are not huge so it is still comprehensive and not too difficult to navigate through. + +Missing article and documentation, not a big deal.