Skip to content

fix: typo approache -> the … approach #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Conversation

danielpeintner
Copy link
Contributor

@danielpeintner danielpeintner commented Jan 10, 2025

fixes #2066


Preview | Diff

@danielpeintner danielpeintner changed the title fix: typo fix: typo approache -> the … approach Jan 10, 2025
Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial, language polish

@egekorkan
Copy link
Contributor

@danielpeintner the prettier action is failing. Did you not allow owners to edit your branch?

@danielpeintner
Copy link
Contributor Author

@danielpeintner the prettier action is failing. Did you not allow owners to edit your branch?

Mhh, I didn't set anything special when it comes to "Branch protection rules".
Do I need to do so to make it work?

@egekorkan
Copy link
Contributor

@danielpeintner when you create the PR, there is the option to allow changes from maintainers or not. That might be the issue. The bot is not allowed to push to your fork. However, @JKRhb has mentioned seeing similar issues. Let us know and we can have a look together as well.

Co-authored-by: Ted Thibodeau Jr <[email protected]>
@egekorkan egekorkan mentioned this pull request Feb 10, 2025
@egekorkan
Copy link
Contributor

egekorkan commented Feb 11, 2025

I have found https://stackoverflow.com/questions/72851548/permission-denied-to-github-actionsbot which hints me to thinking that W3C has changed some settings. I am going to change the workflow file to give more permissions so let's see.

EDIT: I do not have access to the settings page of the TD repo

@egekorkan egekorkan added the Editorial Issues with no technical impact on implementations label Feb 12, 2025
@danielpeintner
Copy link
Contributor Author

I merged in main, and now it seems to work as expected 👍

@egekorkan egekorkan merged commit ee98698 into w3c:main Feb 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editorial Issues with no technical impact on implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo: approache -> the … approach
4 participants