Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup should not close on file navigation initiated by the popup #325

Closed
AidanWelch opened this issue Nov 15, 2022 · 6 comments
Closed

Popup should not close on file navigation initiated by the popup #325

AidanWelch opened this issue Nov 15, 2022 · 6 comments
Labels
follow-up: firefox Needs a response from a Firefox representative inconsistency Inconsistent behavior across browsers

Comments

@AidanWelch
Copy link

Presently, if trying to either saveAs or input a file to a browser extension you have to create a separate tab, and it cannot be done in popup. Clicking within the file navigation initiated by the popup should not close the popup, allowing the popup script to actually be used for file inputting and outputting.

This does slightly expose a risk of a malicious popup spamming file navigation popups, but that doesn't justify removing the functionality entirely. This change would improve both user and developer experience.

@AidanWelch
Copy link
Author

On further testing, Chrome actually does behave this way, but Firefox does not.

@hanguokai
Copy link
Member

Hi @AidanWelch

It looks like a Chrome bug. There was a discussion and a bug for it. But it seems to have been fixed. I can't reproduce this problem in a simple example. If you can, please file a bug and close this issue (because browser-specific bugs are not discussed here).

@AidanWelch
Copy link
Author

Hi @AidanWelch

It looks like a Chrome bug. There was a discussion and a bug for it. But it seems to have been fixed. I can't reproduce this problem in a simple example. If you can, please file a bug and close this issue (because browser-specific bugs are not discussed here).

The issue doesn't occur on Chrome, and as far as I know it isn't an intended feature of Firefox as it doesn't happen in Firefox. I think it is instead an asynchrony in the standard. (Chrome behaves how I described, Firefox doesn't)

@hanguokai
Copy link
Member

Chrome behaves how I described, Firefox doesn't

Do you means it works on Chrome but doesn't work on Firefox? Then it is a Firefox bug. Normally, using <input type=file> or download action in the popup should not cause the popup to be closed.

@AidanWelch
Copy link
Author

Do you means it works on Chrome but doesn't work on Firefox?

Yeah

Then it is a Firefox bug. Normally, using <input type=file> or download action in the popup should not cause the popup to be closed.

Oh okay, I understand. I thought it was intended in Firefox.

@Sxderp
Copy link

Sxderp commented Nov 16, 2022

There are some existing, old, bugs for Firefox.
https://bugzilla.mozilla.org/show_bug.cgi?id=1292701
https://bugzilla.mozilla.org/show_bug.cgi?id=1366330
https://bugzilla.mozilla.org/show_bug.cgi?id=1411000 [tangential]

@dotproto dotproto added inconsistency Inconsistent behavior across browsers follow-up: firefox Needs a response from a Firefox representative labels Mar 2, 2023
@AidanWelch AidanWelch closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
follow-up: firefox Needs a response from a Firefox representative inconsistency Inconsistent behavior across browsers
Projects
None yet
Development

No branches or pull requests

4 participants