Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sandboxed preload scripts are run in the document's script environment #767

Open
jgraham opened this issue Sep 6, 2024 · 1 comment
Open

Sandboxed preload scripts are run in the document's script environment #767

jgraham opened this issue Sep 6, 2024 · 1 comment
Labels
bug Something isn't working module-script Script module

Comments

@jgraham
Copy link
Member

jgraham commented Sep 6, 2024

In https://w3c.github.io/webdriver-bidi/#run-webdriver-bidi-preload-scripts we pass environment settings to evaluate function body, which is wrong in the sandbox case because that environment settings realm is the document's realm, not the sandbox realm.
@whimboo whimboo added bug Something isn't working module-script Script module labels Sep 6, 2024
@jgraham
Copy link
Member Author

jgraham commented Sep 6, 2024

#768 has some attempt at fixing this (albeit whilst still leaving key steps in what sandboxing means undefined).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working module-script Script module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whimboo @jgraham