Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the "browsingContext.navigate" command fail when interrupted by a new navigation? #763

Open
lutien opened this issue Aug 26, 2024 · 1 comment
Labels
module-browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group question Further information is requested

Comments

@lutien
Copy link
Contributor

lutien commented Aug 26, 2024

As far as we understood the html (see https://html.spec.whatwg.org/#beginning-navigation, step 18.1) and WebDriver BiDi spec (see https://w3c.github.io/webdriver-bidi/#await-a-navigation, step 6) the browsingContext.navigate command should fail when interrupted by a new navigation. But it seems like it's causing confusion among users with the pages which trigger a new navigation within the page while this page is still loading (e.g. https://mozilla.org/, https://x.com/). So maybe we should rethink this?

I've also noticed that Chrome actually doesn't throw in these cases. So maybe @sadym-chromium, you could add some details if it was intentional and if you just don't throw when a navigation is interrupted at all or only in specific scenarios?

@lutien lutien added question Further information is requested module-browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group labels Aug 26, 2024
@OrKoN
Copy link
Contributor

OrKoN commented Aug 26, 2024

https://chromium.googlesource.com/chromium/src/+/master/content/public/common/content_features.cc#791 this feature flag sounds like it might be related. I wonder if results would be different with --disable-features=QueueNavigationsWhileWaitingForCommit (cc @sadym-chromium)

UPD: the above flag is probably not related to this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module-browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants