Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MakePublicKeyCredentialOptions? #773

Closed
apowers313 opened this issue Feb 4, 2018 · 4 comments
Closed

Rename MakePublicKeyCredentialOptions? #773

apowers313 opened this issue Feb 4, 2018 · 4 comments

Comments

@apowers313
Copy link
Contributor

I realize this is late in the game, but can we rename MakePublicKeyCredentialOptions to PublicKeyCredentialCreateOptions so that it matches the naming conventions of other APIs? It's just a dictionary (not an interface), so hopefully it would be an easy change...

@selfissued
Copy link
Contributor

I will create a PR to do this unless I hear objections.

@selfissued
Copy link
Contributor

@apowers313 are there any other names that are similarly inconsistent in this way? If so, please name them now. It's getting pretty late to be making changes of this nature.

@nadalin
Copy link
Contributor

nadalin commented Feb 6, 2018

@selfissued Please create PR and we will discuss

@emlun
Copy link
Member

emlun commented Feb 6, 2018

One other case of inconsistent names is the fields of PublicKeyCredentialEntity and its subclasses, as discussed in #646. It was then decided not to do that breaking change so close to CR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants