Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make create() and get() abortable #537

Closed
balfanz opened this issue Aug 21, 2017 · 5 comments
Closed

Make create() and get() abortable #537

balfanz opened this issue Aug 21, 2017 · 5 comments

Comments

@balfanz
Copy link
Contributor

balfanz commented Aug 21, 2017

We need to make sure that create() and get() are abortable: For example, imagine a web page that gives users the ability to dismiss a dialog or popup that takes the user through an Authenticator registration or assertion-generation process. When the user dismisses that dialog or popup, the Authenticator should be notified to, say, stop blinking, callbacks waiting for the create() or get() results should be rejected, etc.

Presumably, we need to add an AbortSignal parameter to both calls to accomplish this: https://dom.spec.whatwg.org/#aborting-ongoing-activities

@AngeloKai
Copy link
Contributor

Adding this parameter is discussed here: #380. I'd expect that on spec level, we just need to extend the WHATWG HTML spec.

@equalsJeffH
Copy link
Contributor

equalsJeffH commented Aug 22, 2017

see also issue #283
issue #316 may be related.

fwiw, terminology-wise, "abort(able)" is being used equivalently to "cancel(able)", both here in webauthn, and in whatwg-land, eg in the abort/cancel proposal in DOM, Fetch, et al.: whatwg/fetch#447

The latter is being implemented now, and is perhaps (ie needs investigation) what we ought to use for our abort/cancel functionality. See: whatwg/fetch#447 (comment), whatwg/fetch#447 (comment)

@AngeloKai
Copy link
Contributor

Resolving this issue would also resolve #116

@nadalin
Copy link
Contributor

nadalin commented Oct 15, 2017

@AngeloKai Where do we stand with this ?

@jcjones jcjones modified the milestones: WD-07, CR Oct 25, 2017
@jcjones
Copy link
Contributor

jcjones commented Nov 9, 2017

Closed by #544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants