Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify which templates include navigation #642

Open
gosko opened this issue Jul 12, 2024 · 0 comments
Open

Clarify which templates include navigation #642

gosko opened this issue Jul 12, 2024 · 0 comments

Comments

@gosko
Copy link
Member

gosko commented Jul 12, 2024

The Basic page template says:

This example shows the minimum required for a basic page. It does not include:
• the complete global navigation

and the navigation menu is omitted from the markup, as expected.

But the Default template and all the other templates say:

This example does not include:
• the complete global navigation

while they do include the nav menu.

Is "does not include the complete global navigation" intended to mean that the nav menu in the examples is incomplete and out of date compared to the live site, or is the nav menu markup intended to be omitted from those pages?

Same comment for the list of links in the footer. I see the footer page says:

This example does not include a complete list of site links in the footer, as which links are included and how they are named can be changed. It only includes a home page link.

So I expect the nav menu is expected to be included on most pages except the Basic page template, and it's just the wording that could use some clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 To do
Development

No branches or pull requests

1 participant