Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enforcement from embed and object elements #486

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

lukewarlow
Copy link
Member

@lukewarlow lukewarlow commented Mar 19, 2024

See #305

Issues:


Preview | Diff

@lukewarlow
Copy link
Member Author

If we decide to merge this we need to make a Chrome and WebKit bug for it and remove/update the tests that cover this.

@lukewarlow lukewarlow marked this pull request as ready for review March 19, 2024 11:57
@lukewarlow lukewarlow marked this pull request as draft March 25, 2024 11:26
@koto
Copy link
Member

koto commented Mar 26, 2024

LGTM

@lukewarlow
Copy link
Member Author

@koto should this wait as per our discussion the other day?

@lukewarlow lukewarlow marked this pull request as ready for review March 26, 2024 16:44
@koto
Copy link
Member

koto commented Mar 26, 2024

We discussed internally at Google and think it's a safe change.

@lukewarlow
Copy link
Member Author

I'm gonna go ahead and merge this change. Test updates will happen accordingly (already basically done just need to finish the webkit patch)

@lukewarlow lukewarlow merged commit c157e39 into w3c:main Apr 4, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Apr 4, 2024
SHA: c157e39
Reason: push, by lukewarlow

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants