Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"allowed to use" check is incorrect #363

Closed
bzbarsky opened this issue Dec 7, 2016 · 2 comments
Closed

"allowed to use" check is incorrect #363

bzbarsky opened this issue Dec 7, 2016 · 2 comments

Comments

@bzbarsky
Copy link

bzbarsky commented Dec 7, 2016

PaymentRequest constructor, step 3.3, says:

If any ancestor browsing context of context has an active document with an origin that is not the same as origin and context's browsing context container's node document is not allowed to use the feature indicated by attribute name allowpaymentrequest, then throw a SecurityError.

So this will check whether the parent document is allowed to use the feature. Shouldn't we be checking whether this document is allowed to use the feature?

@sideshowbarker
Copy link
Contributor

So this will check whether the parent document is allowed to use the feature. Shouldn't we be checking whether this document is allowed to use the feature?

Yes. See #359 (comment). #324 and #332 still need to be fixed—the entire paragraph quoted in the issue description here needs to be revisited/rewritten. It’s not implementable as currently specced.

@sideshowbarker
Copy link
Contributor

Yes. See #359 (comment). #324 and #332 still need to be fixed—the entire paragraph quoted in the issue description here needs to be revisited/rewritten. It’s not implementable as currently specced.

oofs, ignore what I said there—I didn’t realize til just now that the paragraph quoted in the issue description is new from the 056e9f4 change intended to fix #324 and #332.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants