Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-sizing-3] overflow setting should affect min-content #2683

Closed
Dan503 opened this issue May 19, 2018 · 4 comments
Closed

[css-sizing-3] overflow setting should affect min-content #2683

Dan503 opened this issue May 19, 2018 · 4 comments

Comments

@Dan503
Copy link

Dan503 commented May 19, 2018

See #2270 (comment)

https://www.w3.org/TR/css-sizing-3/#valdef-width-min-content

If overflow is set to things other than visible then that should also affect min-content.

If a developer sets overflow: hidden; on a div placed in a css-grid column set to 1fr, currently that div will never allow the overflow to take affect.

Any time a developer sets an overflow property, it is a clear sign that the developer intends for the content to be able to overflow it's container.

@Dan503
Copy link
Author

Dan503 commented May 19, 2018

This is related to issue #2682. They are both trying to solve similar problems. Making the auto part of the 1fr unit behave more like people expect.

@frivoal frivoal added the css-sizing-3 Current Work label May 19, 2018
@fantasai
Copy link
Collaborator

Thanks @Dan503. :) I think I disagree with you specifically on this point: if the author specifically asks the element with overflow to size to its min-content size, then that's what should happen. Otherwise we can't intelligently combine it with other constraints, e.g. width: min-content; max-width: 100% shouldn't be equivalent to width: 0; max-width: 100% if overflow is set.

However, see #1865 for making overflow affect the min-content contribution, which I think will solve the problem you call out in 2270. I really want to fix this, but I have to first prove Web-compatibility, which is hard. :( If you think it'd be worth doing for Grid and Flex only, even if we can't make it happen for Block, please comment there to that effect...

@Dan503
Copy link
Author

Dan503 commented May 21, 2018

Ahh ok, I agree with the direction that the issue discussion is going in that issue. :)

I'm not sure how this affects block display though :/

@tabatkins
Copy link
Member

Yeah, this is a dupe of #1865. Closing so conversation can happen over there instead. ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants