Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revisit prettier automation #2470

Open
pkra opened this issue Mar 7, 2025 · 1 comment
Open

revisit prettier automation #2470

pkra opened this issue Mar 7, 2025 · 1 comment
Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo

Comments

@pkra
Copy link
Member

pkra commented Mar 7, 2025

In #2464 I had re-activated prettier after it had been disabled in #2307.

I don't know if the dry-run option was really relevant. But it disabled the automation and didn't surface the errors. I don't think that was what we wanted.

I'm not sure if the dry-run option was necessary. It looks to me that the failure should be caught by handle-commit-failure anyway?

If it was, then we could change the action to run prettier on commits to main (instead of on PRs).

Alternatively, we could give up on automated formatting and just use dry-run, but surfacing errors (which authors then need to fix).

Or there are other ideas.

@pkra pkra added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label Mar 7, 2025
@daniel-montalvo daniel-montalvo moved this to Todo in ARIA Editors Mar 11, 2025
@pkra pkra moved this from Todo to Agenda+ in ARIA Editors Mar 12, 2025
@pkra
Copy link
Member Author

pkra commented Mar 17, 2025

In light of https://www.stepsecurity.io/blog/harden-runner-detection-tj-actions-changed-files-action-is-compromised (though we luckily don't use tj-actions/changed) perhaps we should reconsider using a third party action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo
Projects
Status: Agenda+
Development

No branches or pull requests

1 participant