Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reporting that an AT did not respond to a command #973

Closed
mcking65 opened this issue Aug 5, 2023 · 2 comments
Closed

Support reporting that an AT did not respond to a command #973

mcking65 opened this issue Aug 5, 2023 · 2 comments
Labels
enhancement New feature or request test-runner

Comments

@mcking65
Copy link
Contributor

mcking65 commented Aug 5, 2023

Problem

If an AT does not respond to a command, the form for collecting responses does not provide a way of indicating that a response did not occur. The input field where users type the output string from a screen reader is required.

Proposed solution

Adjacent to the edit field for AT response, provide a checkbox with label "AT_NAME responded to COMMAND_NAME" that is checked by default.

When the checkbox is checked, the text field for AT response is required. If the checkbox is not checked, the response text field is set to an empty state and disabled.

@ccanash
Copy link

ccanash commented Jan 29, 2024

Hi @mcking65, we were triaging this task and realized we already implemented something similar and deployed it to production here. We wanted to confirm with you if we should implement what is described in this task and/ or if we should make changes to what is already in production. Thank you

@mcking65
Copy link
Contributor Author

The production implementation fully satisfies this requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test-runner
Projects
Development

No branches or pull requests

2 participants