feat: Test Queue v2 #1124

howard-e · 2024-06-05T21:26:12Z

This PR provides an updated version of the Test Queue as described at #791 (comment). It is available on the sandbox for live testing at /test-queue. The previous version is still available at /test-queue-old.

In advancing this work, found that were new design expectations of some of the previously used Test Queue components, found it easier to copy over and make the tweaks rather than bring destructive changes to the old test queue's pieces (and to also verify not breaking expected functionality). As such, there is additional cleanup that will come out of this change such as removing the old test queue or the copied over components, but I'd rather not inflate this PR further and instead follow up in a subsequent PR.

April 8th 2024 Production Release

April 29, 2024 Production Release

…nner-in-support-table

stalgiag · 2024-06-18T19:18:28Z

client/components/ManageTestQueue/ManageAtVersions.jsx

+        title: 'Error Updating Assistive Technology Version'
+    });
+
+    const loadedAts = useRef(false);


Is this used to prevent state updates on initial render? Just noting that this struck me as odd.

Yep. This was originally moved from ManageTestQueue/index.js and there was an attempt to remove it, but found that re-renders were being significantly caused with several actions so opted to just restore that for now.

stalgiag · 2024-06-18T19:20:48Z

client/components/ManageTestQueue/ManageAtVersions.jsx

+        setSelectedAtVersionId(value);
+    };
+
+    const onOpenAtVersionModalClick = type => {


Curious why this pattern is used. Shorter independent functions for each one of these types could improve readability

Agreed, also a copy over but no issue with addressing before landing.

howard-e · 2024-06-18T14:19:32Z

server/migrations/20240516195950-updateMetrics.js

Unsure why this rename happened. My guess is that there is a reason for the metrics values to be re-evaluated but it's not immedidately obvious to me why. The calculatePercent util was changed but not in any significant way but this also shouldn't hurt but something to be aware of.

howard-e · 2024-06-18T19:26:25Z

client/components/ManageTestQueue/ManageAtVersions.jsx

+        title: 'Error Updating Assistive Technology Version'
+    });
+
+    const loadedAts = useRef(false);


Yep. This was originally moved from ManageTestQueue/index.js and there was an attempt to remove it, but found that re-renders were being significantly caused with several actions so opted to just restore that for now.

howard-e · 2024-06-18T19:27:05Z

client/components/ManageTestQueue/ManageAtVersions.jsx

+        setSelectedAtVersionId(value);
+    };
+
+    const onOpenAtVersionModalClick = type => {


Agreed, also a copy over but no issue with addressing before landing.

stalgiag

Looking great! This is a major UI improvement. I left some comments inline. Most are just code quality and organization questions. I also recognize that much of this code wasn't written by others so not expecting you to speak to all of these things. I just wanted to document them for possible tech debt tasks.

I noticed some keyboard interaction issues with the "Add Test Plan to Test Queue" form. Two seem unique to this PR but otherwise happy to approve this as long as we make a list of tech debt follow-ups.

stalgiag · 2024-06-18T19:22:20Z

client/components/ManageTestQueue/ManageAtVersions.jsx

A few questions inline in this file. I think this file could benefit from even more decomposition with managed child components. This can happen in a followup

I noticed some issues with keyboard interaction on latest Chrome.

Unable to open dropdowns with Enter, able to open with VO action key

Unable to tab focus to unselected "Minimum Version" radio

Unable to tab focus to "Select AT Version" or "Select a Browser" dropdown

This item "Unable to open dropdowns with Enter, able to open with VO action key" is true on main so it doesn't need to be addressed with this PR. I would expect this element to interact in the same way as the APG's "Select only Combobox" but "Enter" has no effect.

I noticed some issues with keyboard interaction on latest Chrome.

Unable to open dropdowns with Enter, able to open with VO action key

Not opening with Enter doesn't seem to be new when comparing against what's on main so I'd like us to address this later if needed. But I also can't tell from a quick look on the select spec if this is the expectation -- but in quickly testing a simple example across Safari, Chrome and Firefox, Enter isn't handled in any, but Space is. Is there a reason we should need to handle that?

Unable to tab focus to unselected "Minimum Version" radio

Looks like that's the expected behavior for radiogroups

Unable to tab focus to "Select AT Version" or "Select a Browser" dropdown

Hmmm! I suppose that decision was made to somewhat "improve" the experience since the AT being selected is what impacts which version options and browser options can actually be displayed. Do you think this way is more confusing than not?

This item "Unable to open dropdowns with Enter, able to open with VO action key" is true on main so it doesn't need to be addressed with this PR. I would expect this element to interact in the same way as the APG's "Select only Combobox" but "Enter" has no effect.

Ah should have read ahead! Okay I understand your above point

Looks like that's the expected behavior for radiogroups

Thanks for this! I looked at that example but for some reason, my brain didn't catch the tab vs arrow interaction working across both.

Hmmm! I suppose that decision was made to somewhat "improve" the experience since the AT being selected is what impacts which version options and browser options can actually be displayed. Do you think this way is more confusing than not?

This makes sense! I didn't fully understand the way it was supposed to be used but with that in mind it is an improvement. Thanks for clarifying.

Ah should have read ahead! Okay I understand your above point

Haha I should've went back and edited with a strikethrough. But yes agree that this should happen elsewhere.

I've tested a bunch at this point and feel comfortable saying that any issues I haven't uncovered yet can be fixed in a follow-up. I also feel fine with leaving any or all of the code structure improvements for follow-ups. I'll leave it to you which parts need to land now vs be noted as tech debt. I'll approve. Great work!

stalgiag · 2024-06-18T19:28:55Z

client/components/ManageTestQueue/index.jsx

stalgiag · 2024-06-18T19:42:52Z

client/components/TestQueue2/CompletionStatusListItem/BotTestCompletionStatus/index.js

It feels destructive to lose the commit history on these files in order to move them into the temporary TestQueue2 folder. It also makes it hard to see if there are any changes so I am assuming they remain unchanged.

I did this one as well! I also considered the loss in history as well but didn't want to go through creating new branches in the existing components to support the changes needed. But in retrospect, perhaps that's much easier to handle than what I've included here.

@stalgiag Thanks again for pointing this out, I've pushed c85e494 to address this

stalgiag · 2024-06-18T19:58:52Z

client/hooks/useForceUpdate.js

This feels like a bandaid for improper state management. There are definitely cases where things like this are necessary but it feels like a bad idea to build this directly into the 'show/hide' effects of basic components like our ConfirmationModals.

Good point. I can certainly look more into why this way

howard-e

On Safari, the Exact and Minimum AT Version text leaves their respective radiogroup sections

stalgiag

Approving! See this comment for more.

…sting files to hold a temporary branch to support Test Queue v2 until v1 is removed

howard-e · 2024-06-20T13:56:51Z

client/components/TestQueue2/CompletionStatusListItem/index.jsx

This file is modified version of client/components/TestQueueCompletionStatusListItem/index.js

…label option text

howard-e · 2024-06-20T14:18:39Z

On Safari, the Exact and Minimum AT Version text leaves their respective radiogroup sections

This should be addressed by c04e71e

…anReport as final with just a single tester assigned; instead provide alternate prompt asking confirmation on continuing

…luded elsewhere on reports page

howard-e · 2024-06-20T17:49:45Z

On Safari, the Exact and Minimum AT Version text leaves their respective radiogroup sections

This should be addressed by c04e71e

Reverted this due to a visual problem -- will follow up in a subsequent change to not block on this

This includes work to support #791 and #792. Includes the following changes: * #1055 * #1001 * #1065 * #1052 * #1087 * #1098 * #1092 * #1131 * #1124 --------- Co-authored-by: Howard Edwards <[email protected]> Co-authored-by: Paul Clue <[email protected]> Co-authored-by: alflennik <[email protected]>

Includes the following changes: * #1123, addresses #791 and #792 with: * #1055 * #1001 * #1065 * #1052 * #1087 * #1098 * #1092 * #1131 * #1124 * #1128, addresses #1100 * #1102, addresses #957 * #1132

Paul-Clue and others added 30 commits March 26, 2024 18:50

Save changes

4360be4

Update graphql request

b437907

Merge pull request #1049 from w3c/releases

9d541b1

April 8th 2024 Production Release

Rearrange support table structure

2150fbe

Add AT version

e4dea58

Fix failing test and conditional

36bc827

Remove log

f0b4361

Remove extra span

d6c39bf

Correct commit error

663a738

Fix table column headings

f92bcac

Merge pull request #1063 from w3c/releases

3669e0a

April 29, 2024 Production Release

Cancel out unneccessary code

c6b12c1

Order by AT then browser

9b83341

Temporary changes

5cb2368

Remove unused functions/code

fd6dcb1

Merge branch 'releases'

f51c320

Fix table cell data

dc10f03

Fix iframe height bug

a4b077e

Fix table heading and row order

540c712

Remove comment

e69468a

Show error message with no table

dff75f3

Fix failing tests

c2787fa

Remove console logs

20c72f6

Fix merge conflicts

2f1831f

Add links to table rows

f12437f

Fix recommended reports banner in support table

e1bf19b

Fix merge conflicts

3d046b9

Merge branch 'development' into support-tables-restructure

fe617b5

Merge branch 'support-tables-restructure' into recommended-reports-ba…

783ee53

…nner-in-support-table

Fix color for recommended phase

4e1c768

Satisfy build check

7dae02d

howard-e marked this pull request as ready for review June 13, 2024 22:21

howard-e added 3 commits June 17, 2024 15:08

Update AtVersions e2e test

fa88f20

fix test

4988025

Test timeout in CI

9d8a7fd

howard-e mentioned this pull request Jun 18, 2024

Update project's tabWidth to 2 #969

Merged

stalgiag reviewed Jun 18, 2024

View reviewed changes

howard-e commented Jun 18, 2024

View reviewed changes

stalgiag requested changes Jun 18, 2024

View reviewed changes

howard-e commented Jun 18, 2024

View reviewed changes

stalgiag self-requested a review June 18, 2024 22:02

stalgiag approved these changes Jun 18, 2024

View reviewed changes

Revert creating new automation related files for bot UI -- modify exi…

c85e494

…sting files to hold a temporary branch to support Test Queue v2 until v1 is removed

howard-e commented Jun 20, 2024

View reviewed changes

Prefer 'position: fixed' over 'position: absolute' for the radio box …

c04e71e

…label option text

howard-e added 4 commits June 20, 2024 10:45

Prevent primary test run selection from coming up when marking TestPl…

5064758

…anReport as final with just a single tester assigned; instead provide alternate prompt asking confirmation on continuing

Maintain the sort order of AT name then Browser name that's being inc…

e34fbfa

…luded elsewhere on reports page

typo fix

126645a

Revert

62a23b4

Merge branch 'trends' into test-queue-sandbox

f910ff6

howard-e merged commit 0f42b1d into trends Jun 20, 2024
2 checks passed

howard-e deleted the test-queue-sandbox branch June 20, 2024 20:46

howard-e mentioned this pull request Jun 20, 2024

feat: Trends #1123

Merged

howard-e mentioned this pull request Jun 24, 2024

Create June 24, 2024 Release #1133

Merged

howard-e mentioned this pull request Jul 8, 2024

fix: Remove TestQueue v1 and update Test Queue e2e tests #1146

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Test Queue v2 #1124

feat: Test Queue v2 #1124

howard-e commented Jun 5, 2024 •

edited

Loading

stalgiag Jun 18, 2024

howard-e Jun 18, 2024

stalgiag Jun 18, 2024

howard-e Jun 18, 2024

howard-e Jun 18, 2024

howard-e Jun 18, 2024

howard-e Jun 18, 2024

stalgiag left a comment •

edited

Loading

stalgiag Jun 18, 2024

stalgiag Jun 18, 2024

stalgiag Jun 18, 2024

howard-e Jun 18, 2024 •

edited

Loading

howard-e Jun 18, 2024

stalgiag Jun 18, 2024

stalgiag Jun 18, 2024

stalgiag Jun 18, 2024 •

edited

Loading

howard-e Jun 18, 2024 •

edited

Loading

howard-e Jun 20, 2024

stalgiag Jun 18, 2024

howard-e Jun 18, 2024

howard-e left a comment

stalgiag left a comment

howard-e Jun 20, 2024

howard-e commented Jun 20, 2024

howard-e commented Jun 20, 2024

feat: Test Queue v2 #1124

feat: Test Queue v2 #1124

Conversation

howard-e commented Jun 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stalgiag left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

howard-e Jun 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stalgiag Jun 18, 2024 • edited Loading

Choose a reason for hiding this comment

howard-e Jun 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

howard-e left a comment

Choose a reason for hiding this comment

stalgiag left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

howard-e commented Jun 20, 2024

howard-e commented Jun 20, 2024

howard-e commented Jun 5, 2024 •

edited

Loading

stalgiag left a comment •

edited

Loading

howard-e Jun 18, 2024 •

edited

Loading

stalgiag Jun 18, 2024 •

edited

Loading

howard-e Jun 18, 2024 •

edited

Loading