Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: status for RUNNING tests updates when job status becomes finalized #1094

Merged
merged 2 commits into from
May 16, 2024
Merged

Fix: status for RUNNING tests updates when job status becomes finalized #1094

merged 2 commits into from
May 16, 2024

Conversation

gnarf
Copy link
Contributor

@gnarf gnarf commented May 9, 2024 •
edited
Loading

If a test is still marked as RUNNING when the job becomes COMPLETED, ERROR, or CANCELLED - the RUNNING test should be updated to be ERROR or CANCELLED (COMPLETED should become CANCELLED because the test results were not received)

@gnarf gnarf requested a review from alflennik May 9, 2024 20:46
@howard-e howard-e self-requested a review May 15, 2024 15:45
howard-e
howard-e approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Reviewing the tests made going through this easier as well.

Left an inline comment for clarifying a comment.

server/tests/integration/automation-scheduler.test.js Outdated Show resolved Hide resolved
@gnarf gnarf merged commit a062f63 into development May 16, 2024
2 checks passed
@gnarf gnarf deleted the fix-stuck-running-status branch May 16, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howard-e howard-e howard-e approved these changes

@alflennik alflennik Awaiting requested review from alflennik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnarf @howard-e