Minimum and Exact AT Version #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alflennik
changed the base branch from
development
to
can-duplicate-test-plan-reports
alflennik
changed the base branch from
can-duplicate-test-plan-reports
to
development
This was referenced Apr 24, 2024
howard-e
approved these changes
Apr 24, 2024
| @@ -23,74 +23,6 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'; | |||
| import DisclosureComponentUnstyled from '../common/DisclosureComponent'; | |||
|
|
|||
| const DisclosureContainer = styled.div` | |||
| // Following directives are related to the ManageTestQueue component | |||
There was a problem hiding this comment.
Good catch. This should be its own component too probably. (future thought)
| ); | ||
| }; | ||
|
|
||
| const TextThatWontShiftWhenBold = ({ isBold, children: text }) => { |
| browserId: ID! | ||
| copyResultsFromTestPlanReportId: ID | ||
| copyResultsFromTestPlanVersionId: ID |
|
To reviewers: In a separate discussion with @alflennik we agreed this now introduces breaking changes around the Test Plan Report status dialog. I've added a Currently #1001 is also expected to branch off of this work. |
Co-authored-by: Howard Edwards <[email protected]>
Merged
howard-e
added a commit
that referenced
this pull request
Jun 20, 2024
This includes work to support #791 and #792. Includes the following changes: * #1055 * #1001 * #1065 * #1052 * #1087 * #1098 * #1092 * #1131 * #1124 --------- Co-authored-by: Howard Edwards <[email protected]> Co-authored-by: Paul Clue <[email protected]> Co-authored-by: alflennik <[email protected]>
howard-e
added a commit
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new "minimum" and "exact" AT Version picker to the "Add to test queue" UI. This is part of #791.
Note that the test queue status dialog has not yet been updated and is not expected to work.
This PR resolves also conflicts with the development branch that currently prevent merging
can-duplicate-test-plan-reports. Therefore this diff includes all the changes from that branch. Sorry for the noise. If we usecan-duplicate-test-plan-reportsas a base the number of files changed would actually increase.