Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflow to deploy to production #1050

Merged
merged 1 commit into from
May 9, 2024
Merged

Add workflow to deploy to production #1050

merged 1 commit into from
May 9, 2024

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Apr 8, 2024 •
edited
Loading

Add workflow to automate deployment to aria-at.w3.org on a push to the main branch.

@howard-e howard-e added the enhancement New feature or request label Apr 8, 2024
@howard-e howard-e marked this pull request as draft April 8, 2024 19:58
@howard-e howard-e marked this pull request as ready for review April 10, 2024 16:01
@ccanash ccanash requested a review from alflennik May 7, 2024 15:50
alflennik
alflennik reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@alflennik alflennik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, this type of automation will make the project a lot more approachable and easier to manage. See my one comment but other than that looks good.

.github/workflows/deploy-production.yml
uses: shimataro/ssh-key-action@v2
with:
key: ${{ secrets.DEPLOY_SSH_PRIVATE_KEY }}
known_hosts: ${{ secrets.DEPLOY_KNOWN_HOSTS_PRODUCTION }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable doesn't seem to be defined in GitHub! Is that expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

alflennik
alflennik approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@alflennik alflennik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@alflennik alflennik merged commit 3c53580 into development May 9, 2024
2 checks passed
@alflennik alflennik deleted the automated-deploy-production branch May 9, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alflennik alflennik alflennik approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@howard-e @alflennik