Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section 4 "Model" uses a non-robust Link detection algorithm which does not consider properties #637

Open
trwnh opened this issue Feb 9, 2025 · 0 comments

Comments

@trwnh
Copy link

trwnh commented Feb 9, 2025

https://www.w3.org/TR/activitystreams-core/#model

A JSON object in the Activity Streams 2.0 document is a Link if either: (a) the object contains a type property whose value includes "Link" or (b) any of the types included in the value of the type property are defined as extensions of Link (see Mention for instance); otherwise the JSON object is considered an instance or extension of Object.

We should be able to infer that something is a Link if it has properties of a Link, mainly href. But as written above, the algorithm would declare the following to be an Object:

{
  "href": "https://example.com"
}

The algorithm described above also fails to account for logical inferencing, where the domain of href is specified to be Link.

I think that the paragraph here should be errata'd to add:

... or (c) the object contains a property whose domain is defined as "Link" (see href for instance)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant