Use ASCII serialization for origins #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO
|
|
@annevk, so, we should test e.origin returns a punycode string for an origin containing a unicode IDN, right? If so, any good way to set the domain name in Unicode for WPT? |
|
Yeah, see all the tests I wrote for the change in HTML. There's quite a few tricks to do this and I employed most I think. |
annevk
approved these changes
Jun 26, 2017
jakearchibald
approved these changes
Nov 3, 2017
|
@jungkees if there are tests for |
This patch makes it to use ASCII serialization for (Extendable)MessageEvent.origin instead of Unicode serialization which has been removed from HTML. HTML issue: whatwg/html#2568. HTML change: whatwg/html@c3b2511. Fixes #1142.
jungkees
force-pushed
the
origin-serialization
branch
from
3a5864c to
7c0a94c
Compare
|
Merging the PR. I opened an issue in WPT for adding tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes it to use ASCII serialization for
(Extendable)MessageEvent.origin instead of Unicode serialization which
has been removed from HTML.
HTML issue: whatwg/html#2568.
HTML change: whatwg/html@c3b2511.
Fixes #1142.
Preview | Diff