Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry 1.2 #271

Merged
merged 18 commits into from
Oct 3, 2022
Merged

Poetry 1.2 #271

merged 18 commits into from
Oct 3, 2022

Conversation

vwxyzjn
Copy link
Owner

@vwxyzjn vwxyzjn commented Sep 10, 2022

Description

Adopting poetry 1.2 support. The locking and adding dependencies are orders of magnitude faster!

Types of changes

  • Bug fix
  • New feature
  • New algorithm
  • Documentation

Checklist:

  • I've read the CONTRIBUTION guide (required).
  • I have ensured pre-commit run --all-files passes (required).
  • I have updated the documentation and previewed the changes via mkdocs serve.
  • I have updated the tests accordingly (if applicable).

@vercel
Copy link

vercel bot commented Sep 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cleanrl ✅ Ready (Inspect) Visit Preview Oct 3, 2022 at 4:39PM (UTC)

@vwxyzjn
Copy link
Owner Author

vwxyzjn commented Sep 27, 2022

@Dipamc77 and @dosssman this PR is ready for review.

@dosssman
Copy link
Collaborator

dosssman commented Oct 1, 2022

@vwxyzjn Hello there.
Attempted to test the workflow from scratch by installing poetry 1.2.1 as per their docs using this command: curl -sSL https://install.python-poetry.org | python3 -, but running poetry install in cleanrl directory while under the poetry1.2 branch just hangs.
Is it on my side only ?

$ poetry install
Creating virtualenv cleanrl-iXm2iEAu-py3.9 in /home/d055/.cache/pypoetry/virtualenvs
Installing dependencies from lock file

Package operations: 67 installs, 1 update, 0 removals

  • Installing certifi (2022.6.15.1): Pending...
  • Installing charset-normalizer (2.1.1): Pending...
  • Installing idna (3.3): Pending...
  • Installing pyasn1 (0.4.8): Pending...
  • Installing pyparsing (3.0.9): Pending...
  • Installing urllib3 (1.26.12): Pending...

Or is my luck just that bad today ? 😅

@vwxyzjn
Copy link
Owner Author

vwxyzjn commented Oct 2, 2022

@dosssman could you try export PYTHON_KEYRING_BACKEND=keyring.backends.null.Keyring? I think it's related to python-poetry/poetry#1917

@dosssman
Copy link
Collaborator

dosssman commented Oct 2, 2022

Thanks a lot. This seems to have done the trick now.

Copy link
Collaborator

@dosssman dosssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looking good over here.
Great work.

docs/get-started/installation.md Show resolved Hide resolved
Copy link
Collaborator

@kinalmehta kinalmehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Test done as follows:

  • Installation successful
  • Did not check if every script ran perfectly. Only tested one for each environment (atari, gym, mujoco, envpool, procgen) and framework (JAX and PyTorch)

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants