Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor documentation #121

Closed
10 tasks done
Tracked by #115
vwxyzjn opened this issue Feb 22, 2022 · 0 comments
Closed
10 tasks done
Tracked by #115

Refactor documentation #121

vwxyzjn opened this issue Feb 22, 2022 · 0 comments

Comments

@vwxyzjn
Copy link
Owner

vwxyzjn commented Feb 22, 2022

What is the problem

The current documentation requires more work. First, some of the implemented algorithms such as Apex-DQN, TD3, and SAC are not documented at https://docs.cleanrl.dev. Second, even the documented algorithm such as PPO does not have complete documentation: for example, the ppo_atari_envpool.py is not really documented. Third, there doesn't seem to be a single-source place to put documentation.

Going forward, I'd like to impose a specific documentation style and improve the overall workflow, which will also help #117.

Proposed solution

I was thinking maybe we can put a documentation link at the beginning of each file. For example, we could add these two lines at ppo.py.

https://github.com/vwxyzjn/cleanrl/blob/c8faef93fc8dbc9528183840ab75b8962df7b9c4/cleanrl/ppo.py#L1-L7

And this link of https://cleanrl-553u0zazz-vwxyzjn.vercel.app/rl-algorithms/ppo/#ppopy will point to the corresponding documentation that has

  • Brief overview of the algorithm
  • Original paper and relevant resources
  • Short description of what ppo.py specifically does
  • Explanation of important implementation details
  • Experiment results (and how they compare to the original paper or/and other reference implementations)
  • Learning curves
  • Tracked experiments

Which roughly looks like below (haven't added the tracked experiments)

ppodemo.mp4

List of files needed to add documentation

@vwxyzjn vwxyzjn mentioned this issue Feb 22, 2022
19 tasks
@vwxyzjn vwxyzjn changed the title Re-think documentation (what, where, and how to put documentation). Refactor documentation Feb 23, 2022
@vwxyzjn vwxyzjn pinned this issue Mar 12, 2022
@vwxyzjn vwxyzjn closed this as completed Jun 1, 2022
@vwxyzjn vwxyzjn unpinned this issue Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant