-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
feat(VCombobox): always show only matching suggestions #22093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Menu gets unstable (opens, closes, opens, etc.) again after typing few more characters with no match.
I deliberately removed isPristine from useFilter(...) to have filterdItems predictable and depending only on the search and _searchLock (to be introduced in one of the outstanding PRs). I don't mind having it back if we can avoid regression... just feeling like we made a wrong turn at some point and state/behavior is very hard to track and impossible to keep the bugs out.
66648e1 to
69af7c3
Compare
I think this looks good, added 1 test case scenario ready for round of review thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏼
We need an entry in new-in.json and a description for API docs that would include "matching", "suggestions" keywords and a hint about :menu-icon="false" and hide-selected for optimal UX.
All done let me know if it's correct Jacek thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion it is more of a fix than a feature. We just deliver it using a separate prop to avoid unexpected behavior change in all the use cases where it is expected to act like an enhanced VAutocomplete.
Description
closes #22060
Relates to: #21901
alwaysFilterdefaults tofalseto allow the previous behavior consistent with components likeVSelectandVAutocompleteIf set totrueit will prevent to set theisPristinetofalseon initial loadInstead of passing thesearchimmediately checkisPristineand determine the value to passMarkup: