Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VSparkline): accept numeric value for smooth #20795

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

J-Sek
Copy link
Contributor

@J-Sek J-Sek commented Dec 19, 2024

Description

fixes #19262

Markup:

<template>
  <v-app>
    <v-container>
      <v-sparkline :model-value="values" :smooth="4" />
      <v-sparkline :model-value="values" smooth />
      <v-sparkline :model-value="values" smooth="1" />
      <v-sparkline :model-value="values" :smooth="1" />
    </v-container>
  </v-app>
</template>

<script setup>
  const values = [80, 75, 60, 55, 65, 60, 62, 58, 55, 65, 60, 68, 62, 58, 65, 70, 65, 75, 70]
</script>

@J-Sek J-Sek requested a review from johnleider January 15, 2025 10:57
@J-Sek J-Sek self-assigned this Jan 15, 2025
@J-Sek J-Sek added T: bug Functionality that does not work as intended/expected C: VSparkline labels Jan 15, 2025
@KaelWD KaelWD merged commit 0f833be into vuetifyjs:master Jan 16, 2025
10 checks passed
@J-Sek J-Sek deleted the fix/19262 branch January 16, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VSparkline T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.5.5] VSparkline has incorrect types for properties "smooth" and "labels"
3 participants