Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vlistgroup): fixed icon not displaying using kebab-case #15293

Conversation

louisdelphie
Copy link

added prepend-icon and append-icon to slot.

fix #8676

Description

Added !this.$slots['append-icon']/!this.$slots['prepend-icon'] to the if condition.
Added this.$slots['append-icon']/this.$slots['prepend-icon'] to the $createElement function
call in genAppendIcon/genPrependIcon functions.
fixes #8676

Motivation and Context

#8676 #8676

How Has This Been Tested?

I tested visually

Markup:

// Paste your FULL Playground.vue here
{{ iconName }} Users <script> export default { data: () => ({ iconName: 'people_outline', admins: [ ['Management', 'people_outline'], ['Settings', 'settings'], ], cruds: [ ['Create', 'add'], ['Read', 'insert_drive_file'], ['Update', 'update'], ['Delete', 'delete'], ], }), } </script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@KaelWD KaelWD changed the base branch from master to v2-stable February 5, 2023 09:55
@MajesticPotatoe MajesticPotatoe added T: bug Functionality that does not work as intended/expected C: VListGroup VListGroup labels Aug 14, 2023
KaelWD added a commit that referenced this pull request Feb 12, 2024
@github-actions github-actions bot closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VListGroup VListGroup T: bug Functionality that does not work as intended/expected
Projects
None yet
2 participants