-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vlistgroup): fixed icon not displaying using kebab-case #15293
Closed
louisdelphie
wants to merge
2
commits into
vuetifyjs:v2-stable
from
louisdelphie:fix/#8676-issue-with-using-prepend-icon
Closed
fix(vlistgroup): fixed icon not displaying using kebab-case #15293
louisdelphie
wants to merge
2
commits into
vuetifyjs:v2-stable
from
louisdelphie:fix/#8676-issue-with-using-prepend-icon
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added prepend-icon and append-icon to slot. fix vuetifyjs#8676
MajesticPotatoe
added
T: bug
Functionality that does not work as intended/expected
C: VListGroup
VListGroup
labels
Aug 14, 2023
KaelWD
added a commit
that referenced
this pull request
Feb 12, 2024
This was referenced Jul 17, 2024
This was referenced Jul 25, 2024
This was referenced Sep 12, 2024
This was referenced Sep 15, 2024
This was referenced Sep 17, 2024
This was referenced Sep 19, 2024
This was referenced Sep 24, 2024
This was referenced Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added prepend-icon and append-icon to slot.
fix #8676
Description
Added !this.$slots['append-icon']/!this.$slots['prepend-icon'] to the if condition.
Added this.$slots['append-icon']/this.$slots['prepend-icon'] to the $createElement function
call in genAppendIcon/genPrependIcon functions.
fixes #8676
Motivation and Context
#8676 #8676
How Has This Been Tested?
I tested visually
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).