Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript throwing type error #1022

Merged
merged 3 commits into from
Mar 27, 2022
Merged

Fix typescript throwing type error #1022

merged 3 commits into from
Mar 27, 2022

Conversation

A-Ghorab
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

i rechecked the previous changes to typescript and i extended the solution to fix current errors that we have
i had an error when added a multiple validation for the same field

so to fix it this will check the 3 cases

  1. Nested Children with validations
  2. Multiple validations
  3. Single validation line.

also i made the validation arguments optional you don't always need to validate every field.

fix typescript types issue
make the validation arguments optional. it's not always needed to validate everything
some cleaning and reuse the already built in ValidationRuleCollection
@dobromir-hristov dobromir-hristov merged commit 073f3d8 into vuelidate:next Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants