Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useStore() type definition is missing parameter for storeKey. #1807

Closed
DerAlbertCom opened this issue Aug 2, 2020 · 2 comments
Closed

useStore() type definition is missing parameter for storeKey. #1807

DerAlbertCom opened this issue Aug 2, 2020 · 2 comments
Labels
types Related to typings only

Comments

@DerAlbertCom
Copy link

Version

4.0.0-beta.4

Steps to reproduce

In the Vue4 type definition the useStore function is defined as

export function useStore<S = any>(): Store<S>;

but in the source you can provide a key, to enable more then one store in the application.

export function useStore (key = null) {

What is expected?

The type definition should match the function

What is actually happening?

It does not match ;) so only one store can be used with typescript

@euaaaio
Copy link
Contributor

euaaaio commented Aug 3, 2020

PR is already made 🤘🏻

@kiaking kiaking added the types Related to typings only label Aug 4, 2020
@kiaking
Copy link
Member

kiaking commented Oct 30, 2020

Closing due to the PR is already merged!

@kiaking kiaking closed this as completed Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
types Related to typings only
Projects
None yet
Development

No branches or pull requests

3 participants