Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs($zh): fix typos #2542

Merged
merged 1 commit into from
Aug 18, 2020
Merged

docs($zh): fix typos #2542

merged 1 commit into from
Aug 18, 2020

Conversation

qige2016
Copy link
Contributor

@qige2016 qige2016 commented Jul 30, 2020

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@qige2016 qige2016 changed the title docs: fix typo docs($zh): fix typos Aug 2, 2020
@bencodezen
Copy link
Member

My Chinese abilities are limited, but it seems like 编译器 is more commonly used than 编译期. But I defer to native speakers on this one.

@meteorlxy
Copy link
Member

meteorlxy commented Aug 18, 2020

@bencodezen

编译器 refers to "compiler", while 编译期 refers to the "compilation phase" (or "compile-time" in the en docs).

So this could be a valid typo fix. 😉

@meteorlxy meteorlxy merged commit ce81aa4 into vuejs:master Aug 18, 2020
@bencodezen
Copy link
Member

Thanks so much for the clarification @meteorlxy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants