fix #855 Stop observing add/remove of files in node_modules #856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #855
When running vuepress dev, chokidar is set to observe all
addition/removal of md files inside the current folder.
node_modules
is one of the observed folders and can contain tons of subfolders. It mostly never contains any md files. Even more rarely has it any hot additions of md files.Another perk of this fix is this: If for some reason a developer
decided to publish a folder with a weird name in its module. It will not
prevent
vuepress dev
from loading.Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
node 8.11.4
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: