fix: exclude dest folder from pageFiles (fixes #654) #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulivz
requested changes
Jul 17, 2018
lib/prepare/resolveOptions.js
Outdated
| if (siteConfig.dest) { | ||
| // exclude dest folder from pageFiles | ||
| const outDirRelative = path.relative(sourceDir, outDir) | ||
| files.push('!' + siteConfig.dest) |
There was a problem hiding this comment.
You just created a new variable, but where do you use it?
There was a problem hiding this comment.
Sorry about that, fixed now.
ulivz
approved these changes
Jul 27, 2018
ulivz
added a commit
that referenced
this pull request
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #654
Dest folder, if present in the config, gets excluded from pageFiles to prevent parsing errors if any .md file's present.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)