Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong OutboundLink insertion position when link contains elements #496

Closed
yyx990803 opened this issue May 24, 2018 · 3 comments
Closed

Wrong OutboundLink insertion position when link contains elements #496

yyx990803 opened this issue May 24, 2018 · 3 comments
Labels
type: bug Something isn't working

Comments

@yyx990803
Copy link
Member

If a link contains other inline elements (either bold, italics or <code>):

[some **link** with `code`](https://google.com)

The outbound link icon is inserted only after the first segment (i.e. after some).

ref #428
@yyx990803 yyx990803 added the type: bug Something isn't working label May 24, 2018
@ulivz
Copy link
Member

ulivz commented May 24, 2018

Will fix it soon.

@ulivz
Copy link
Member

ulivz commented May 24, 2018 •
edited
Loading

In order to avoid such issue with a bad impact, recently I was working for a full UT coverage of the core code (#480), Hey, Evan, if you have any ideas, please let me know. thanks!

@ulivz ulivz closed this as completed in af96f28 May 24, 2018
@ulivz
Copy link
Member

ulivz commented May 24, 2018

Fixed it at af96f28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yyx990803 @ulivz