Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix home link '/' shouldn’t always stays active #47

Merged
merged 2 commits into from
Apr 15, 2018
Merged

Fix home link '/' shouldn’t always stays active #47

merged 2 commits into from
Apr 15, 2018

Conversation

dyhpoon
Copy link
Contributor

@dyhpoon dyhpoon commented Apr 15, 2018

so if i add a home route as follows
screen shot 2018-04-15 at 8 57 09 pm

the home link remains active even I am at a different page
screen shot 2018-04-15 at 8 57 24 pm

@yyx990803 yyx990803 merged commit 67c758e into vuejs:master Apr 15, 2018
@LinusBorg LinusBorg mentioned this pull request Apr 15, 2018
Closed
@dyhpoon dyhpoon deleted the fix_home_link_always_active branch April 16, 2018 01:25
@snyk-bot snyk-bot mentioned this pull request Sep 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egoist egoist egoist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dyhpoon @egoist @yyx990803