Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve custom theme from global cli (#392) #399

Merged
merged 2 commits into from
May 10, 2018
Merged

fix: resolve custom theme from global cli (#392) #399

merged 2 commits into from
May 10, 2018

Conversation

meteorlxy
Copy link
Member

Details in #392

Reference Modules | Node.js Documentation

ulivz
ulivz requested changes May 10, 2018
View reviewed changes
Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using path.resolve('../') instead of path.resolve(__dirname) can avoid the meaningless lookup of the current directory.

@meteorlxy
Copy link
Member Author

Hmmm you're right. path.resolve(__dirname, '../node_modules') could be better?

ulivz
ulivz approved these changes May 10, 2018
View reviewed changes
Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulivz ulivz merged commit 01142df into vuejs:master May 10, 2018
@meteorlxy meteorlxy deleted the fix-global-resolve branch May 11, 2018 07:13
@ulivz ulivz mentioned this pull request May 11, 2018
Closed
@stasson stasson mentioned this pull request Apr 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulivz ulivz ulivz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meteorlxy @ulivz