Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat($theme-default): add code group and code block components #2594

Merged
merged 7 commits into from
Sep 9, 2020
Merged

feat($theme-default): add code group and code block components #2594

merged 7 commits into from
Sep 9, 2020

Conversation

d-pollard
Copy link
Collaborator

@d-pollard d-pollard commented Sep 2, 2020

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Before:
Screen Shot 2020-09-02 at 12 26 08 PM

After:
Screen Shot 2020-09-02 at 12 27 03 PM
Screen Shot 2020-09-02 at 12 30 11 PM

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@bencodezen bencodezen self-requested a review September 2, 2020 17:41
@d-pollard
Copy link
Collaborator Author

After styling, this is the updated design:

Screen Shot 2020-09-02 at 1 50 16 PM

Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @d-pollard!

@bencodezen bencodezen merged commit 394c4f6 into vuejs:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants