-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix($theme-default): overlap navbar dropdown menus (fix #2227) #2365
Conversation
1a01c2b
to
4c0d29e
Compare
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixed this issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks the this PR!
BTW, I find that when a PR fixes multiple issues, it is better for the contributors to write some background to describe it, otherwise the CR people will need to spend a lot of time to digest and understand, maybe it could be part of the contribution requirement. // cc @bencodezen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@billyyyyy3320 Do you want to address the comment from @ulivz before merging? |
I upgraded to the latest version and there was an error,Is there a problem with local dependence?
Error: F:\workSpaces\source-code\ibooks\node_modules@vuepress\theme-default\components\DropdownLink.vue:156:15 |
@JoeyBling Can you try deleting your node_modules folder and reinstalling the dependencies? If it's still a problem, please be sure to create a new issue so we can help look into it! |
@bencodezen Re installing dependencies is ok
|
Summary
fix #2227 #2492
Also see:
#2234
#2303
#2339
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: