Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SidebarGroup does not use @theme alias #2049

Closed
1 task done
florevallatmrf opened this issue Nov 29, 2019 · 0 comments · May be fixed by adamlaska/osmos-cosmos-sdk#5
Closed
1 task done

SidebarGroup does not use @theme alias #2049

florevallatmrf opened this issue Nov 29, 2019 · 0 comments · May be fixed by adamlaska/osmos-cosmos-sdk#5
Labels
topic: theme Relates to VuePress theme type: enhancement Request to enhance an existing feature

Comments

@florevallatmrf
Copy link

florevallatmrf commented Nov 29, 2019 •
edited
Loading

  • I confirm that this is an issue rather than a question.

Bug report

Steps to reproduce

  • Using the default theme
  • Shadow the SidebarLinks component

What is expected?

All instances of SidebarLinks in the app should use the shadowed version

What is actually happening?

Only first level groups are using the shadowed version, because SidebarGroup is not using the @theme alias when importing the component:
https://github.com/vuejs/vuepress/blob/master/packages/@vuepress/theme-default/components/SidebarGroup.vue#L66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: theme Relates to VuePress theme type: enhancement Request to enhance an existing feature
Projects
None yet
Milestone
No milestone
2 participants
@meteorlxy @florevallatmrf