-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix($theme-default): wrong algolia search route with base config #2007
Conversation
Thanks @SigureMo, is the problem only occurring with algolia? |
Yes, default search does not have this problem. You can take a look at my another documention. |
Is this going to solve #1802 as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 One more approval to merge
Would love to see this merged! Very important fix :) |
Hey @SigureMo, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
Summary
Fix #1929
Fix #1802
Fix algolia search route is not correct in the case that
$site.base
is not/
.For example, in my project documention, I search some keywords, it will route to
https://www.xxx.com/$site.base/$size.base/path/to/page/#hash
rather thanhttps://www.xxx.com/$site.base/path/to/page/#hash
,$site.base
is repeat.What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: