Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($theme-default): wrong algolia search route with base config #2007

Merged
merged 1 commit into from
Nov 27, 2019
Merged

fix($theme-default): wrong algolia search route with base config #2007

merged 1 commit into from
Nov 27, 2019

Conversation

SigureMo
Copy link
Contributor

@SigureMo SigureMo commented Nov 7, 2019

Summary

Fix #1929
Fix #1802

Fix algolia search route is not correct in the case that $site.base is not /.

For example, in my project documention, I search some keywords, it will route to https://www.xxx.com/$site.base/$size.base/path/to/page/#hash rather than https://www.xxx.com/$site.base/path/to/page/#hash, $site.base is repeat.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@SigureMo SigureMo changed the title fix($theme-default): fix algolia search route bug fix($theme-default): fix algolia search route is not correct Nov 7, 2019
@kefranabg
Copy link
Collaborator

Thanks @SigureMo, is the problem only occurring with algolia?

@SigureMo
Copy link
Contributor Author

SigureMo commented Nov 10, 2019

@kefranabg

Yes, default search does not have this problem. You can take a look at my another documention.

@haoranpb
Copy link
Contributor

Is this going to solve #1802 as well?

Copy link
Collaborator

@kefranabg kefranabg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 One more approval to merge

@AaronCnvrg
Copy link

Would love to see this merged! Very important fix :)

@meteorlxy meteorlxy changed the title fix($theme-default): fix algolia search route is not correct fix($theme-default): wrong algolia search route with base config Nov 27, 2019
@meteorlxy meteorlxy merged commit b00b277 into vuejs:master Nov 27, 2019
@vue-bot
Copy link

vue-bot commented Nov 27, 2019

Hey @SigureMo, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search "plugin" does not include project base in url Algolia search redirects with duplicated base url
6 participants