Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat($core): Upgrade vue version #1876

Merged
merged 3 commits into from
Sep 24, 2019
Merged

feat($core): Upgrade vue version #1876

merged 3 commits into from
Sep 24, 2019

Conversation

kefranabg
Copy link
Collaborator

@kefranabg kefranabg commented Sep 21, 2019

Summary

There is already a PR to upgrade vue version in vuepress, but is now outdated. I created a new one with the latest versions.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe: Upgrade deps

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, but could you help check if Markdown Slot has been affected?

@flozero
Copy link
Collaborator

flozero commented Sep 22, 2019

Markdown slot @kefranabg is in some md you write <component #header /> if I remember well

@flozero
Copy link
Collaborator

flozero commented Sep 22, 2019

As you create a new one i close this one #1370

@kefranabg
Copy link
Collaborator Author

Markdown slots still working ! 🎉

@ulivz
Copy link
Member

ulivz commented Sep 23, 2019

Unfortunately there is a conflict that should be addressed.

@kefranabg
Copy link
Collaborator Author

Resolved!

@kefranabg kefranabg merged commit c17c70e into master Sep 24, 2019
@kefranabg kefranabg deleted the feat/upgrade-vue-version branch September 24, 2019 17:08
@vue-bot
Copy link

vue-bot commented Sep 24, 2019

Hey @kefranabg, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants