Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$page variable doesn't gets set probably on urls without a trailing slash #183

Closed
peXed opened this issue Apr 20, 2018 · 1 comment
Closed
Labels
type: bug Something isn't working

Comments

@peXed
Copy link

peXed commented Apr 20, 2018

OS: Windows 10
Node: 8.10.0
VuePress: 0.6.1
Browser: Chrome 65
Local install
Package manager: Yarn

Bug:
If you visit a route without a trailing slash, the $page variable doesn't gets set probably and the page won't render correctly.
You also don't get redirected to the path with the trailing slash.

How to reproduce:

  1. Clone offical repository
  2. Run dev server (yarn dev)
  3. Open a route without the taling slash (e.g. localhost:8080/guide )

Expected Behavior:
You get redirected to the correct path (with the trailing).
This would fix potential SEO problems as well (for more infos: https://webmasters.googleblog.com/2010/04/to-slash-or-not-to-slash.html?m=1 )

Issue is linked to: #144

@ulivz
Copy link
Member

ulivz commented Apr 20, 2018

Thanks, Fixed at #185

@ulivz ulivz added the type: bug Something isn't working label Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants