Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "ENOTDIR: not a directory" error #1564

Merged
merged 2 commits into from
May 11, 2019
Merged

Fix "ENOTDIR: not a directory" error #1564

merged 2 commits into from
May 11, 2019

Conversation

ocavue
Copy link
Contributor

@ocavue ocavue commented Apr 25, 2019

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

fix #1563

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@ocavue ocavue changed the title [WIP] Fix "ENOTDIR: not a directory" error Fix "ENOTDIR: not a directory" error Apr 25, 2019
Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and could you add test cases for it?

@ocavue
Copy link
Contributor Author

ocavue commented Apr 26, 2019

Sure, I will add some tests this weekend.

@ocavue
Copy link
Contributor Author

ocavue commented Apr 29, 2019

@ulivz Tests have been added.

@ocavue
Copy link
Contributor Author

ocavue commented May 7, 2019

@ulivz Any time to review this?

@ulivz ulivz merged commit 057d8bf into vuejs:master May 11, 2019
@vue-bot
Copy link

vue-bot commented May 11, 2019

Hey @ocavue, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: ENOTDIR: not a directory when using "layouts/Layout.vue" as entry file
3 participants