Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat($core): prevent duplicate route #1525

Merged
merged 4 commits into from
Apr 14, 2019
Merged

feat($core): prevent duplicate route #1525

merged 4 commits into from
Apr 14, 2019

Conversation

shigma
Copy link
Collaborator

@shigma shigma commented Apr 7, 2019

Summary

If we add multiple pages with the same path (i.e. theme has already provided a homepage but we want to override it), VuePress client will break with the following message:

[vue-router] Duplicate named routes definition: { name: "v-b2754d56", path: "" }

This PR prevent from adding duplicate route. If a duplicate route was to be add, it will override the old one.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@shigma shigma requested a review from ulivz April 7, 2019 02:33
@shigma shigma requested a review from ulivz April 14, 2019 02:07
@ulivz ulivz merged commit 441f023 into master Apr 14, 2019
@shigma shigma deleted the prevent-duplicate-route branch April 14, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants