Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nav url change bug (#865) #1475

Merged
merged 1 commit into from
Mar 24, 2019
Merged

fix nav url change bug (#865) #1475

merged 1 commit into from
Mar 24, 2019

Conversation

KyleJShaver
Copy link
Contributor

@KyleJShaver KyleJShaver commented Mar 24, 2019

Summary
Fixes issue #865 wherein if the bottom element is too small, navigating to the hash will cause the url to change to the element displayed at the top of the page. For example:

The Problem:
navigation changing unexpectedly
Note how clicking on "Advanced Configuration" causes the "Insert Code Snippets" navigation item to be selected and hash to be reflected in the URL

Fixed:
navigation remaining consistent
Note how clicking on "Advanced Configuration" remains selected

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
The added logic only kicks in if the user is navigating to the very bottom of the page.

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@ulivz ulivz merged commit 521dddd into vuejs:master Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants