Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Hero Header should allow for optional h1 text #1326

Merged
merged 1 commit into from
Feb 24, 2019
Merged

Proposal: Hero Header should allow for optional h1 text #1326

merged 1 commit into from
Feb 24, 2019

Conversation

ahmadnassri
Copy link
Contributor

this is useful when data.heroImage can act as the "header" (e.g. logo & label of product / application are present in image)

  • allow removing the h1 tag when data.heroText is NULL
  • allow passing data.heroAlt to define alt text value.

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Before

image

After

with data.heroText === null

image

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • [ x IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
    • I have not updated docs yet, but I will if this is given 👍
  • Related tests have been updated
    • this will need new tests, happy to provide them if this is given 👍

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

- allow removing the h1 tag when `data.heroText` is `NULL`
- allow passing `data.heroAlt` to define alt text.

this is useful when `data.heroImage` can act as the "header"
@ulivz ulivz merged commit 598799f into vuejs:master Feb 24, 2019
@ahmadnassri ahmadnassri deleted the patch-1 branch February 26, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants